Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Holocene Channel Bank Checks #572

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 25, 2024

Description

Adds checks to the ChannelBank for post-holocene strict ordering that only one channel may only be buffered at a given point in time within the channel queue.

Closes #558

Copy link
Collaborator Author

refcell commented Sep 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @refcell and the rest of your teammates on Graphite Graphite

@refcell refcell changed the title feat(derive): holocene channel bank checks feat(derive): Holocene Channel Bank Checks Sep 25, 2024
@refcell refcell requested a review from clabby September 25, 2024 01:24
@refcell refcell added A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature labels Sep 25, 2024 — with Graphite App
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.2%. Comparing base (7952058) to head (7d979aa).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell marked this pull request as ready for review September 25, 2024 01:24
@refcell refcell self-assigned this Sep 25, 2024
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. It'd be nice to add a quick unit test that covers the case where the channel queue is cleared, when a new frame is sent during an existing channel's buffer period.

crates/derive/src/stages/channel_bank.rs Show resolved Hide resolved
@refcell refcell force-pushed the rf/feat/channel-bank-checks branch from 69d1462 to 350460f Compare September 27, 2024 20:02
@refcell refcell force-pushed the rf/feat/channel-bank-checks branch from 544c08e to 082fdb2 Compare September 27, 2024 20:20
@refcell refcell added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 2002e33 Sep 27, 2024
17 checks passed
This was referenced Sep 27, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOLOCENE] feat(derive): ChannelBank Strict Ordering
2 participants