-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(derive): Holocene Channel Bank Checks #572
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. It'd be nice to add a quick unit test that covers the case where the channel queue is cleared, when a new frame is sent during an existing channel's buffer period.
69d1462
to
350460f
Compare
544c08e
to
082fdb2
Compare
Description
Adds checks to the
ChannelBank
for post-holocene strict ordering that only one channel may only be buffered at a given point in time within the channel queue.Closes #558