Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Holocene Buffer Flushing #575

Merged
merged 2 commits into from
Sep 27, 2024
Merged

feat(derive): Holocene Buffer Flushing #575

merged 2 commits into from
Sep 27, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Sep 26, 2024

Description

Small PR to add buffer flushing to the batch stream.

Copy link
Collaborator Author

refcell commented Sep 26, 2024

@refcell refcell changed the title feat(derive): holocene buffer flushing feat(derive): Holocene Buffer Flushing Sep 26, 2024
@refcell refcell requested a review from clabby September 26, 2024 13:51
@refcell refcell added A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature labels Sep 26, 2024 — with Graphite App
@refcell refcell marked this pull request as ready for review September 26, 2024 13:51
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.4%. Comparing base (a610b16) to head (a222220).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch_stream.rs 0.0% 5 Missing ⚠️
crates/derive/src/pipeline/builder.rs 0.0% 2 Missing ⚠️
crates/derive/src/stages/channel_reader.rs 0.0% 2 Missing ⚠️
crates/derive/src/stages/batch_queue.rs 50.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell self-assigned this Sep 26, 2024
@refcell refcell force-pushed the rf/feat/wire-up-batch-span-stage branch 2 times, most recently from 6af6cdd to dac37f6 Compare September 26, 2024 19:19
@refcell refcell changed the base branch from rf/feat/wire-up-batch-span-stage to main September 26, 2024 22:05
@refcell refcell added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit ccd3f14 Sep 27, 2024
16 of 17 checks passed
This was referenced Sep 27, 2024
This was referenced Oct 9, 2024
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants