Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): BatchStream buffering #590

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat(derive): BatchStream buffering #590

merged 4 commits into from
Sep 30, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 30, 2024

Overview

Implements the rest of the BatchStream, buffering the span batch that is received and sending only SingleBatches to the batch queue.

@clabby clabby added K-feature Kind: feature A-derive Area: kona-derive crate labels Sep 30, 2024
@clabby clabby self-assigned this Sep 30, 2024
@clabby clabby marked this pull request as draft September 30, 2024 19:13
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 99.10714% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.1%. Comparing base (ed6f8f9) to head (5f5c3fc).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch_stream.rs 99.1% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review September 30, 2024 19:29
@clabby clabby requested a review from refcell September 30, 2024 19:38
@refcell
Copy link
Collaborator

refcell commented Sep 30, 2024

Dawg: #576

@refcell
Copy link
Collaborator

refcell commented Sep 30, 2024

Assignee: #559

@clabby
Copy link
Collaborator Author

clabby commented Sep 30, 2024

Dawg: #576

oop, mb - thought this was something different, closing. Need this for #561

@clabby clabby closed this Sep 30, 2024
@clabby clabby reopened this Sep 30, 2024
@clabby clabby force-pushed the cl/fix-batch-stream branch from 9b7eef7 to 8ea6783 Compare September 30, 2024 21:14
Copy link
Collaborator Author

clabby commented Sep 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 40a47f0 Sep 30, 2024
18 checks passed
This was referenced Oct 8, 2024
This was referenced Oct 9, 2024
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants