Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(derive): Span batch prefix checks #592

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat(derive): Span batch prefix checks #592

merged 4 commits into from
Sep 30, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Sep 30, 2024

Overview

Adds the checks for the span batch prefix.

@clabby clabby self-assigned this Sep 30, 2024
Copy link
Collaborator Author

clabby commented Sep 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby added K-feature Kind: feature A-derive Area: kona-derive crate labels Sep 30, 2024
@clabby clabby marked this pull request as draft September 30, 2024 21:14
@clabby clabby force-pushed the cl/span-prefix-checks branch from 449da19 to b53f75b Compare September 30, 2024 21:18
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

crates/derive/src/stages/batch_stream.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 64.61538% with 46 lines in your changes missing coverage. Please review.

Project coverage is 79.9%. Comparing base (40a47f0) to head (297e116).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/batch/span_batch/batch.rs 61.7% 36 Missing ⚠️
crates/derive/src/stages/batch_stream.rs 78.7% 7 Missing ⚠️
crates/derive/src/pipeline/builder.rs 0.0% 2 Missing ⚠️
crates/derive/src/batch/mod.rs 0.0% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/span-prefix-checks branch from 17b44df to 70b3227 Compare September 30, 2024 22:12
@clabby clabby changed the base branch from cl/fix-batch-stream to main September 30, 2024 22:12
@clabby clabby marked this pull request as ready for review September 30, 2024 22:12
@clabby clabby force-pushed the cl/span-prefix-checks branch from 70b3227 to 297e116 Compare September 30, 2024 22:13
@clabby clabby added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 9e9c002 Sep 30, 2024
17 of 18 checks passed
@github-actions github-actions bot mentioned this pull request Sep 30, 2024
This was referenced Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-derive Area: kona-derive crate K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants