Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(derive): BatchValidator stage #703

Merged
merged 7 commits into from
Oct 19, 2024
Merged

feat(derive): BatchValidator stage #703

merged 7 commits into from
Oct 19, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 17, 2024 •
edited
Loading

Overview

Adds a new stage to take place of the BatchQueue after Holocene activation, the BatchValidator. This stage's only role is to consume the SingleBatches from the BatchStream, validate them, and send them off to the AttributesQueue.

This PR does not hook this stage up to a multiplexer stage with the BatchQueue, and that will be done in a follow-up.

@clabby clabby self-assigned this Oct 17, 2024
@clabby clabby added H-holocene Hardfork: Holocene related K-feature Kind: feature A-derive Area: kona-derive crate labels Oct 17, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.98861% with 22 lines in your changes missing coverage. Please review.

Project coverage is 94.3%. Comparing base (5ae6a53) to head (30c78f5).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/stages/batch/batch_validator.rs 94.9% 22 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/batch-sequencer branch 4 times, most recently from f842945 to 084e7f1 Compare October 19, 2024 04:11
@clabby clabby linked an issue Oct 19, 2024 that may be closed by this pull request
feat(derive): BatchValidator stage #714
Closed
@clabby clabby marked this pull request as ready for review October 19, 2024 04:20
@clabby clabby requested a review from refcell as a code owner October 19, 2024 04:20
@clabby clabby force-pushed the cl/batch-sequencer branch from f25c54f to 30c78f5 Compare October 19, 2024 06:27
refcell
refcell approved these changes Oct 19, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but it seems like there's a lot of duplicate logic with the batch_queue. Is it not possible to de-dup into a split out validator that holds the l1 blocks? Happy to allow any enhancements to be follow on since this works.

crates/derive/src/stages/batch/batch_validator.rs Show resolved Hide resolved
@clabby clabby added this pull request to the merge queue Oct 19, 2024
Merged via the queue into main with commit 49c3118 Oct 19, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2024
Merged
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
@clabby
feat(derive): BatchValidator stage (op-rs#703)
ef10225 
* feat(derive): `BatchValidator` stage

* tests

* lint

* tests

tests

* 🧹

* tests

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(derive): BatchValidator stage
2 participants
@clabby @refcell