Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove thiserror #735

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: Remove thiserror #735

merged 1 commit into from
Oct 25, 2024

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 25, 2024 •
edited
Loading

Description

Completely removes the thiserror dependency, allowing us to publish our crates. Instead of deriving the core::error::Error type, we manually implement along with using derive_more::Display.

@refcell
Copy link
Collaborator Author

refcell commented Oct 25, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@refcell refcell requested a review from clabby as a code owner October 25, 2024 16:25
@refcell refcell self-assigned this Oct 25, 2024
@refcell refcell force-pushed the rf/feat/remove-thiserror branch from e0aea66 to 3cb7e3e Compare October 25, 2024 16:38
@refcell refcell added K-feature Kind: feature A-workspace Area: Top level workspace modifications F-deps Flag: Updates dependencies labels Oct 25, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.11765% with 73 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@330deeb). Learn more about missing BASE report.
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/derive/src/errors.rs 30.7% 27 Missing ⚠️
crates/executor/src/errors.rs 0.0% 19 Missing ⚠️
crates/preimage/src/errors.rs 0.0% 11 Missing ⚠️
crates/derive/src/batch/span_batch/errors.rs 0.0% 8 Missing ⚠️
crates/mpt/src/errors.rs 0.0% 8 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 89a69a4 Oct 25, 2024
17 checks passed
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Merged
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
@refcell
feat: remove thiserror (op-rs#735)
2942766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

Assignees

@refcell refcell

Labels
A-workspace Area: Top level workspace modifications F-deps Flag: Updates dependencies K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby