Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misprint in tflint args example #119

Closed
volk1234 opened this issue Jun 23, 2020 · 1 comment
Closed

Misprint in tflint args example #119

volk1234 opened this issue Jun 23, 2020 · 1 comment

Comments

@volk1234
Copy link

volk1234 commented Jun 23, 2020 •
edited
Loading

There are 2 examples of using args in Notes about terraform_tflint hooks chapter:

hooks:
  - id: terraform_tflint
    args: ['args=--deep']

This not works with tflint inside pre-commit hook. Clean tflint with the parameters work for me.

As far as I can see from the hook's bash script this should be with two minuses before internal args parameter, e.g.

hooks:
  - id: terraform_tflint
    args: ['--args=--deep']

This one works for me.
So it looks like it not and issue in the code but the wrong documented parameter.
@robinbowes robinbowes mentioned this issue Jul 6, 2020
Merged
@antonbabenko
Copy link
Owner

This has been fixed in #125

v1.33.0 has been just released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antonbabenko @volk1234