fix: update legend marker #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
为啥看上去会小一点了？ |
|
CI 挂了…… [!] (plugin commonjs) TypeError: hostOrText.readFile is not a function
TypeError: hostOrText.readFile is not a function
at readJsonOrUndefined (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:19519:74)
at Object.readJson (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:19528:16)
at getPackageJsonInfo (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:44772:41)
at nodeLoadModuleByRelativeName (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:44426:54)
at tryResolve (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:44380:34)
at /Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:44343:69
at Object.forEach (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:181:30)
at nodeModuleNameResolverWorker (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:44343:25)
at Object.nodeModuleNameResolver (/Users/runner/work/G2/G2/node_modules/typescript/lib/typescript.js:44313:16)
at Object.resolveId (/Users/runner/work/G2/G2/node_modules/rollup-plugin-typescript/dist/rollup-plugin-typescript.cjs.js:155:28) |
因为之前直接取得包围盒做为 marker 的小，但是 stroke 是没有计入包围盒大小当中的，所以有 stroke 的marker 是比实际尺寸偏大的。现在把stroke计算进来后，看起来比之前就略小了 |
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
更新 GUI 版本后更新 G2 截图
主要变动：