-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update legend component inferring strategies #4906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Apr 23, 2023
为啥需要这个限制? |
没有颜色的话或者单一颜色,绘制连续比例尺应该没有意义 |
pearmini
requested changes
Apr 23, 2023
图例组件推断关系
legendCategory
legendContinuousSize
legendContinuousBlockSize
legendContinuousBlock
legendContinuous
|
pearmini
approved these changes
Apr 23, 2023
这个我们周一一起筛查一下,究竟哪些是需要显示图例的。比如:单测截图中的但颜色的 size 图例,就感觉默认不太合理,虽然用户通过 api 都可以调整,但是最好还是默认就相对来说是好用好看的。 |
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* fix: add extra rules to avoid unexcept component inferring * refactor: update legend inferring config
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
* fix: add extra rules to avoid unexcept component inferring * refactor: update legend inferring config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过比例尺推断组件添加了额外的规则:
fixed #4904