fix: chart.options changeData problem #4936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearmini
requested changes
May 5, 2023
|
处理一下冲突，这个 PR 可以现合并，之后实现了 updateRoot 之后把相关代码删除了就好了。 |
pepper-nice
force-pushed
the
fix/chart-changeData
branch
from
148bbdc to
adc77cb
Compare
pearmini
requested changes
May 5, 2023
pearmini
approved these changes
May 5, 2023
pr-triage
bot
added
PR: reviewed-approved
and removed
PR: reviewed-changes-requested
labels
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
hustcc
pushed a commit
that referenced
this pull request
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题描述
使用 spec 方式申明 Chart 时，调用 changeData 不生效。
原因：因为 changeData 通过
this.attr('data', data)来更新 data，对 options 中的 data 无法做更改。解决方法
chart 复写 changeData 方法，调用一次
this.options({ data: newData })