Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport issues found #12

Open
magjac opened this issue Sep 13, 2018 · 1 comment
Open

Backport issues found #12

magjac opened this issue Sep 13, 2018 · 1 comment

Comments

@magjac
Copy link
Contributor

magjac commented Sep 13, 2018

I ended up copying the dotparser grammar to my own project, since I needed to add line number information and whitespace, newline and comment nodes to the ast and I didn't think that that would be generally useful. During that work I found a couple of issues that I fixed without reporting them here.

You might want to have a look at https://github.com/magjac/graphviz-visual-editor/commits/master/src/dotGrammar.pegjs to see if there are any fixes you'd like to backport to dotparser.

@anvaka
Copy link
Owner

anvaka commented Oct 20, 2018

Thank you! I couldn't tell which issues are critical?

Your website http://magjac.com/graphviz-visual-editor/ looks very good though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants