Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on Windows (shards install uses make bin) #20

Open
drhuffman12 opened this issue Sep 6, 2021 · 0 comments
Open

Broken on Windows (shards install uses make bin) #20

drhuffman12 opened this issue Sep 6, 2021 · 0 comments

Comments

@drhuffman12
Copy link

drhuffman12 commented Sep 6, 2021

When I run on Windows, I get a Postinstall error

Run shards install
Resolving dependencies
Fetching https://github.com/lbguilherme/crystal-coverage.git
Installing coverage (0.1.0 at 4148e9e)
Postinstall of coverage: make bin
Error: Process completed with exit code 1.

For clarification, I run shards install in a build for https://github.com/drhuffman12/crystal-coverage-example. See the .github/workflows/ci.yml file in that repo; it basically looks like below, but with some tweeks:

jobs:
  build:
    # TODO: Get the Windows builds working...
    # continue-on-error: ${{ matrix.os.windows-latest }}
    strategy:
      fail-fast: false
      matrix:
        os: [ubuntu-latest, macos-latest, windows-latest]
        # os: [ubuntu-latest, macos-latest]
        crystal: [null]
        include:
          - os: ubuntu-latest
            crystal: nightly
    runs-on: ${{matrix.os}}

    steps:
      - name: Build
        run: shards install

      - name: Test
        run: crystal spec

      - name: Check formatting
        run: crystal tool format --check src spec

      - name: Check code coverage
        run: bin/crystal-coverage
...

(For now, I'll refactor my ci.yml to only run coverage on the linux part of the ci matrix. That's good enough for me, but some people might need to run coverage on a Windows box.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant