New clippy lints in solana-sbf-rust-invoke

[brooksprumo]

There are new clippy lints when upgrade nightly rust to 2024-11-22 (1.84.0), which causes CI to fail:

error: large array defined as const
    --> rust/invoke/src/lib.rs:1440:13
     |
1440 |             const ZEROS: [u8; 256 * 1024] = [0; 256 * 1024];
     |             -----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     |             |
     |             help: make this a static item: `static`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays
     = note: `-D clippy::large-const-arrays` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::large_const_arrays)]`

error: could not compile `solana-sbf-rust-invoke` (lib test) due to 1 previous error

I used this cmd to reproduce locally, from within programs/sbf/:

cargo +nightly-2024-11-22 clippy --workspace --all-targets --features dummy-for-ci-check,frozen-abi --keep-going -- --deny=warnings --deny=clippy::default_trait_access --deny=clippy::arithmetic_side_effects --deny=clippy::manual_let_else --deny=clippy::used_underscore_binding

Should this array be static? Or a slice? Or add a clippy-allow? Or change how the assert is checked (e.g. use an iter that always returns 0s)?

Child of #4380

[brooksprumo]

@pgarg66 Here's another one. I'm not sure what the right fix is, so it would be helpful to have someone on your team handle this correctly. Thanks in advance!

[pgarg66]

@pgarg66 Here's another one. I'm not sure what the right fix is, so it would be helpful to have someone on your team handle this correctly. Thanks in advance!

@LucasSte could you help take a look?

[LucasSte]

I'll have a look!

[LucasSte]

I simply switched to static in #4503. I explained the reason in the PR's summary. Let's wait for the CI to turn green now 🤞

[LucasSte]

Closing the issue, since #4503 was merged.