Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS A AODN-Portal developer I WANT to check the UI tests after new feature SO THAT can pass the playwright test #244

Closed
3 tasks
NekoLyn opened this issue Dec 20, 2024 · 4 comments · Fixed by #249
Assignees

Comments

@NekoLyn
Copy link
Contributor

NekoLyn commented Dec 20, 2024

Acceptance Criteria

1.playwright test pass

Notes

1.please check the UI changes in the ticket https://github.com/aodn/backlog/issues/6059 (can find all the changes in 'demo' section)
image

Tasks

Preview Give feedback

PRs

  1. Features/6116 spatial map focus detail map #251
  2. Playwright: fix skipped map tests #258

Dependencies

Demo

@utas-raymondng
Copy link
Contributor

The above PR fixed most of the skip, the map is still skip. @AR-RIFAT can you take a look? I believe it is due to some testid change

@AR-RIFAT
Copy link
Collaborator

AR-RIFAT commented Jan 5, 2025

@utas-raymondng I could not find any more skipped tests in the linked PR branch. Can you tell me the name of the test function that is skipped?

@utas-raymondng
Copy link
Contributor

utas-raymondng commented Jan 5, 2025

Didn't aware that you put a fix in

#249

I merged it today and test failed in the test_map.py can you kindly help to check? it may be cause by new changes, so I put a skip to the test_map.py

pytestmark = pytest.mark.skip(reason="Temporarily skipping all search tests")

@utas-raymondng
Copy link
Contributor

Item fixed so I close the issue, @NekoLyn please update your main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants