Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Table chart metric header right align #719

Closed
stuarthu opened this issue Jul 31, 2020 · 5 comments
Closed

Table chart metric header right align #719

stuarthu opened this issue Jul 31, 2020 · 5 comments
Labels
css #enhancement New feature or request

Comments

@stuarthu
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Table chart metric number is right aligned, but the header is not.

Describe the solution you'd like
Metric header is right aligned

Describe alternatives you've considered
Alternatively, we can make metric number left aligned.

Additional context

Expect result:

截屏2020-07-31 11 56 51

@issue-label-bot issue-label-bot bot added the #enhancement New feature or request label Jul 31, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.90. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@mistercrunch
Copy link
Contributor

For consistency I think all headers should be left aligned and the sort icons should be right next to the header works.

@ktmud
Copy link
Contributor

ktmud commented Jul 31, 2020

For consistency I think all headers should be left aligned and the sort icons should be right next to the header works.

Numeric values are easier to read when right aligned. You may find the same design principle in various design guides.

I'll make the header for metrics right aligned (or a pull request is also welcome).

@stuarthu
Copy link
Contributor Author

I tried to bring a PR but that is beyond my skills.

@stuarthu
Copy link
Contributor Author

fixed in #721

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css #enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants