Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AFS.verifyReserved with a condition #4908

Open
kevinrr888 opened this issue Sep 19, 2024 · 0 comments
Open

Replace AFS.verifyReserved with a condition #4908

kevinrr888 opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Milestone

Comments

@kevinrr888
Copy link
Member

kevinrr888 commented Sep 19, 2024

Is your feature request related to a problem? Please describe.
With the changes from #4524, reservations are now indicated in a column for UserFateStore. For writes like push(), pop(), etc. that require the transaction to be reserved, could instead add a condition to the FateMutator that ensures the FateId is reserved.

Describe the solution you'd like
A new method added to FateMutator that adds the condition that the FateId is reserved: FateMutator<T> requireReserved();. verifyReserved() would no longer be needed for UserFateStore, but would still be needed for MetaFateStore.

This should wait until after #4907 is completed

@kevinrr888 kevinrr888 added the enhancement This issue describes a new feature, improvement, or optimization. label Sep 19, 2024
@kevinrr888 kevinrr888 added this to the 4.0.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue describes a new feature, improvement, or optimization.
Projects
None yet
Development

No branches or pull requests

1 participant