Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always re-serialise DAGs after an upgrade #19533

Closed
2 tasks done
uranusjr opened this issue Nov 11, 2021 · 1 comment
Closed
2 tasks done

Always re-serialise DAGs after an upgrade #19533

uranusjr opened this issue Nov 11, 2021 · 1 comment
Assignees
@uranusjr
Labels
area:core area:serialization kind:feature Feature Requests

Comments

@uranusjr
Copy link
Member

Description

#19519 (comment)

Also I think we have a new "dags reserialize" coming - #19471 - which is really good idea because the "serialized" form of DAGs is pretty safe to delete and recreate.

I just wonder if this is not something that we should always do after/during upgrade "just in case". It might slow-down initial dag refresh, but at least we can be sure that everything in serialized dags is "correct".

Recording this in a new issue so it doesn’t get forgotten.

Use case/motivation

No response

Related issues

A way to manually trigger DAG reserialisation:
#19471

If a previous-serialised DAG is not being compatible with new semantics, a bug can be raised at a confusing location:
#19519

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@uranusjr uranusjr added the kind:feature Feature Requests label Nov 11, 2021
@uranusjr uranusjr mentioned this issue Nov 17, 2021
Closed
@dstandish
Copy link
Contributor

closed following discussion on #19637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uranusjr uranusjr

Labels
area:core area:serialization kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Trigger DAG re-serialization after upgrade uranusjr/airflow
3 participants
@uranusjr @dstandish @eladkal