Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering public google common hooks base_hook get_credentials public breaks ComputeEngineHook because that class still refers to the private method #28573

Closed
2 tasks done
zazaho opened this issue Dec 24, 2022 · 2 comments · Fixed by #28588
Closed
2 tasks done

rendering public google common hooks base_hook get_credentials public breaks ComputeEngineHook because that class still refers to the private method #28573

zazaho opened this issue Dec 24, 2022 · 2 comments · Fixed by #28588
Assignees
@zazaho
Labels
kind:bug This is a clearly a bug provider:google Google (including GCP) related issues

Comments

@zazaho
Copy link
Contributor

zazaho commented Dec 24, 2022

Apache Airflow version

2.5.0

What happened

I was trying to use the example fo creating a google compute VM instance and the code crashes with a AttributeError: ComputeEngineHook has no attribute _get_credentials

What you think should happen instead

No response

How to reproduce

modify the ComputeEngineHook to call get_credentials

Operating System

linux

Versions of Apache Airflow Providers

latest I believe, not sure

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@zazaho zazaho added area:core kind:bug This is a clearly a bug labels Dec 24, 2022
@zazaho
Copy link
Contributor Author

zazaho commented Dec 25, 2022

related PR: #28588

@Taragolis Taragolis added provider:google Google (including GCP) related issues and removed area:core labels Dec 25, 2022
@Taragolis Taragolis linked a pull request Dec 25, 2022 that will close this issue
replace private _get_credentials by public get_credentials #28588
Merged
@briva
Copy link

briva commented Jan 7, 2023

Same pb

@briva briva mentioned this issue Jan 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zazaho zazaho

Labels
kind:bug This is a clearly a bug provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace private _get_credentials by public get_credentials zazaho/airflow
3 participants
@briva @Taragolis @zazaho