Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataprocCreateBatchOperator in deferrable mode doesn't reattach with deferment. #32215

Closed
2 tasks done
kristopherkane opened this issue Jun 27, 2023 · 0 comments · Fixed by #32216
Closed
2 tasks done
Assignees
Labels
area:providers kind:bug This is a clearly a bug provider:google Google (including GCP) related issues

Comments

@kristopherkane
Copy link
Contributor

Apache Airflow version

main (development)

What happened

The DataprocCreateBatchOperator (Google provider) handles the case when a batch_id already exists in the Dataproc API by 'reattaching' to a potentially running job.

Current reattachment logic uses the non-deferrable method even when the operator is in deferrable mode.

What you think should happen instead

The operator should reattach in deferrable mode.

How to reproduce

Create a DAG with a task of DataprocCreateBatchOperator that is long running. Make DataprocCreateBatchOperator deferrable in the constructor.

Restart local Airflow to simulate having to 'reattach' to a running job in Google Cloud Dataproc.

The operator resumes using the running job but in the code path for the non-derferrable logic.

Operating System

macOS 13.4.1 (22F82)

Versions of Apache Airflow Providers

Current main.

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@kristopherkane kristopherkane added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Jun 27, 2023
@hussein-awala hussein-awala added provider:google Google (including GCP) related issues area:providers and removed needs-triage label for new issues that we didn't triage yet area:core labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:bug This is a clearly a bug provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants