Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpAsyncHook headers #32390

Closed
1 task done
eladkal opened this issue Jul 6, 2023 · 1 comment · Fixed by #32409
Closed
1 task done

Fix HttpAsyncHook headers #32390

eladkal opened this issue Jul 6, 2023 · 1 comment · Fixed by #32409

Comments

@eladkal
Copy link
Contributor

eladkal commented Jul 6, 2023

Body

The hook uses _headers:

if headers:
_headers.update(headers)

but passes headers to the async function

response = await request_func(
url,
json=data if self.method in ("POST", "PATCH") else None,
params=data if self.method == "GET" else None,
headers=headers,
auth=auth,
**extra_options,
)

The task:

headers=headers needs to be headers=_headers

There was attempt to address it in #31010 but the PR become stale as no response from the author.

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@sumeshpremraj
Copy link
Contributor

Hi @eladkal , I'd like to take this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants