Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request help: use name instead of id in grafana dashboard #5149

Closed
starsz opened this issue Sep 28, 2021 · 7 comments
Closed

request help: use name instead of id in grafana dashboard #5149

starsz opened this issue Sep 28, 2021 · 7 comments

Comments

@starsz
Copy link
Contributor

starsz commented Sep 28, 2021

Issue description

Hi, I found that now we use the service id and route id in the grafana dashboard.
Which is not friendly to read. So I recommend we can use name instead of id in the grafana dashboard.

Now:
image
image

Environment

  • apisix version (cmd: apisix version): 2.6
  • OS (cmd: uname -a):
  • OpenResty / Nginx version (cmd: nginx -V or openresty -V):
  • etcd version, if have (cmd: run curl http://127.0.0.1:9090/v1/server_info to get the info from server-info API):
  • apisix-dashboard version, if have:
  • the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner):
  • luarocks version, if the issue is about installation (cmd: luarocks --version):
@spacewander
Copy link
Member

spacewander commented Sep 28, 2021

The default label of Prometheus is id but not name. So by default, the grafana doesn't know the name.

@starsz
Copy link
Contributor Author

starsz commented Oct 5, 2021

Yes.I think we can use the name as the label of Prometheus if the name exists?

@spacewander
Copy link
Member

spacewander commented Oct 7, 2021

No. It will be a break change. We can't change it in 2.x at least.

@starsz
Copy link
Contributor Author

starsz commented Oct 8, 2021

No. It will be a break change. We can't change it in 2.x at least.

In another way, we can add a config to switch the label.

@spacewander
Copy link
Member

Do you mean a config for grafana? We have such a config for prometheus.

@starsz
Copy link
Contributor Author

starsz commented Oct 9, 2021

Oh. I see. We had already supported it.

http://apisix.apache.org/docs/apisix/plugins/prometheus

@lifehacking
Copy link

@starsz how solved label name view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants