Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependency #9279

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Remove circular dependency #9279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efa0650
remove circular dependency
andygrove Feb 19, 2024
7b8619e
ignore rustdoc
andygrove Feb 19, 2024
2180588
ignore rustdoc
andygrove Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion datafusion/physical-expr/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ uuid = { version = "^1.2", features = ["v4"] }

[dev-dependencies]
criterion = "0.5"
datafusion = { workspace = true }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, why we added this dependency. Looks not correct. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was added to allow for some example code in rustdoc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this on initial review.

rand = { workspace = true }
rstest = { workspace = true }
tokio = { workspace = true, features = ["rt-multi-thread"] }
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-expr/src/datetime_expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ pub fn make_current_time(
///
/// # Examples
///
/// ```
/// ```ignore
/// # use chrono::prelude::*;
/// # use datafusion::prelude::*;
/// # use datafusion::error::Result;
Expand Down
6 changes: 3 additions & 3 deletions datafusion/physical-expr/src/regex_expressions.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ macro_rules! fetch_string_arg {
///
/// # Examples
///
/// ```
/// ```ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

/// # use datafusion::prelude::*;
/// # use datafusion::error::Result;
/// # #[tokio::main]
Expand Down Expand Up @@ -136,7 +136,7 @@ pub fn regexp_like<T: OffsetSizeTrait>(args: &[ArrayRef]) -> Result<ArrayRef> {
///
/// # Examples
///
/// ```
/// ```ignore
/// # use datafusion::prelude::*;
/// # use datafusion::error::Result;
/// # #[tokio::main]
Expand Down Expand Up @@ -216,7 +216,7 @@ fn regex_replace_posix_groups(replacement: &str) -> String {
///
/// # Examples
///
/// ```
/// ```ignore
/// # use datafusion::prelude::*;
/// # use datafusion::error::Result;
/// # #[tokio::main]
Expand Down
Loading