Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl ArrowNativeType for i128 #1098

Closed
liukun4515 opened this issue Dec 27, 2021 · 3 comments
Closed

impl ArrowNativeType for i128 #1098

liukun4515 opened this issue Dec 27, 2021 · 3 comments
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@liukun4515
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

when I implement the comparison operation for decimal data type, I should support i128 for

pub fn extend_from_slice<T: ToByteSlice>(&mut self, items: &[T]) {
this function.

In the pr #779, The i128 has been added as ArrowNativeType, but this is change-api changes.

how should i continue this work?

@alamb
Can I cherry-pick part code of this #779 to release branch

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@liukun4515 liukun4515 added the enhancement Any new improvement worthy of a entry in the changelog label Dec 27, 2021
@alamb
Copy link
Contributor

alamb commented Dec 28, 2021

I think back porting just the impl ArrowNativeType for i128 is a reasonable thing to do for the release branch.

The main reason it has the api-change label is that it adds a new enum variant for IntervalUnit

However, I expect that arrow 6.5.0 will be the last release created before the release of 7.0.0 (which I expect in 2 weeks time)

@liukun4515
Copy link
Contributor Author

I think back porting just the impl ArrowNativeType for i128 is a reasonable thing to do for the release branch.

The main reason it has the api-change label is that it adds a new enum variant for IntervalUnit

However, I expect that arrow 6.5.0 will be the last release created before the release of 7.0.0 (which I expect in 2 weeks time)

Thanks for your feedback.

Now we use i128 to u8 slice to represent the decimal value, and we use the FixedsizeListBuilder to append decimal value. If the i128 is as the ArraowNativeType, maybe we can change it to the Int128Builder to append decimal value.

@alamb
Copy link
Contributor

alamb commented Jan 21, 2022

@alamb alamb closed this as completed Jan 21, 2022
@alamb alamb changed the title support i128 as the ArrowNativeType impl ArrowNativeType for i128 Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants