Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WON'T FIX) Don't Interwine Bit and Byte Aligned Operations in BitReader #1282

Closed
tustvold opened this issue Feb 7, 2022 · 0 comments
Closed

Comments

@tustvold
Copy link
Contributor

tustvold commented Feb 7, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

BitReader contains a mixture of byte-aligned APIs such as get_aligned and get_vlq_int along with bit-aligned APIs such as get_value and get_batch. This makes the implementation kind of hard to follow, there is a buffer but this is only used for bit-level APIs, there is a bit_offset, but this is not used for some APIs, etc...

Describe the solution you'd like

Explicitly split the implementation of aligned APIs that operate on the byte stream from unaligned APIs that operate on the bit stream.

Describe alternatives you've considered

The current code is not incorrect and could remain unchanged

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Feb 7, 2022
@alamb alamb removed the enhancement Any new improvement worthy of a entry in the changelog label Feb 16, 2022
@alamb alamb changed the title Don't Interwine Bit and Byte Aligned Operations in BitReader (WON'T FIX) Don't Interwine Bit and Byte Aligned Operations in BitReader Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants