Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CI Checks #1578

Closed
tustvold opened this issue Apr 17, 2022 · 3 comments
Closed

Require CI Checks #1578

tustvold opened this issue Apr 17, 2022 · 3 comments
Labels
development-process Related to development process of arrow-rs

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Currently prior to merge you need to check all the CI bar MIRI has run to completion. This is somewhat tiresome and potentially error prone.

Describe the solution you'd like

All CI checks bar MIRI should be required prior to merge. I don't know who has access to change this, perhaps @andygrove ??

Describe alternatives you've considered

We could not do this

@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Apr 17, 2022
@alamb
Copy link
Contributor

alamb commented Apr 17, 2022

I personally like the flexibility of not requiring CI checks (it allows me to accelerate things like README updates or if clippy has released a new breaking change).

That being said, I am not opposed to this change; I just feel like it actually adds more burden on the maintainers.

In terms of changing settings, I think apache projects don't control github settings directly, instead they check in a config file that then sets the permissions.

https://github.com/apache/arrow-rs/blob/master/.asf.yaml

@tustvold
Copy link
Contributor Author

If memory serves there is a way to override on a case-by-case basis, but potentially that require repos admin 🤔

I'll close this as I don't feel particularly strongly, I just thought it might be an oversight

@alamb
Copy link
Contributor

alamb commented Apr 18, 2022

I'll close this as I don't feel particularly strongly, I just thought it might be an oversight

I think it is more like "arrow has always done it this way and it seems useful to me"

@alamb alamb added development-process Related to development process of arrow-rs and removed enhancement Any new improvement worthy of a entry in the changelog labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

No branches or pull requests

2 participants