Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type_id and value_offset are incorrect for sliced UnionArray #2086

Closed
viirya opened this issue Jul 16, 2022 · 0 comments · Fixed by #2087
Closed

type_id and value_offset are incorrect for sliced UnionArray #2086

viirya opened this issue Jul 16, 2022 · 0 comments · Fixed by #2087
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Jul 16, 2022

Describe the bug

UnionArray.value has considered slicing case so it adjusts given index with self.offset() when calling type_idandvalue_offset. But type_idandvalue_offset` are incorrect by itself when they are called separately. We should fix them.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@viirya viirya added the bug label Jul 16, 2022
@viirya viirya mentioned this issue Jul 16, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Jul 21, 2022
@alamb alamb changed the title type_id and value_offset are incorrect for sliced UnionArray type_id and value_offset are incorrect for sliced UnionArray Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

type_id and value_offset are incorrect for sliced UnionArray viirya/arrow-rs
2 participants
@viirya @alamb