Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support peek_next_page and skip_next_page in InMemoryPageReader #2406

Closed
Ted-Jiang opened this issue Aug 11, 2022 · 0 comments · Fixed by #2407
Closed

Support peek_next_page and skip_next_page in InMemoryPageReader #2406

Ted-Jiang opened this issue Aug 11, 2022 · 0 comments · Fixed by #2407
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate

Comments

@Ted-Jiang
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
when i was implementing bench using skip_records got

Benchmarking arrow_array_reader/Int32Array/binary packed skip, mandatory, no NULLs: Warming up for 3.0000 sthread 'main' panicked at 'not implemented', /CLionProjects/github/arrow-rs/parquet/src/util/test_common/page_util.rs:169:9

which is unimplemented

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@Ted-Jiang Ted-Jiang added the enhancement Any new improvement worthy of a entry in the changelog label Aug 11, 2022
@Ted-Jiang Ted-Jiang mentioned this issue Aug 11, 2022
Merged
@alamb alamb added the parquet Changes to the parquet crate label Aug 17, 2022
@alamb alamb changed the title Support peek_next_page and skip_next_page in InMemoryPageReader Support peek_next_page and skip_next_page in InMemoryPageReader Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support peek_next_page and skip_next_page in InMemoryPageReader Ted-Jiang/arrow-rs
2 participants
@alamb @Ted-Jiang