Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the field StructBuilder::len #2429

Closed
HaoYang670 opened this issue Aug 12, 2022 · 0 comments · Fixed by #2468
Closed

Remove the field StructBuilder::len #2429

HaoYang670 opened this issue Aug 12, 2022 · 0 comments · Fixed by #2468
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We can get the length of the StructBuilder from the null buffer builder.
So the field StructBuilder::len is useless and we should remove it.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Aug 12, 2022
@HaoYang670 HaoYang670 mentioned this issue Aug 12, 2022
Merged
@psvri psvri mentioned this issue Aug 16, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove len field from StructBuilder psvri/arrow-rs
2 participants
@alamb @HaoYang670