Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Float Array should not panic on DivideByZero in the Divide kernel #2719

Closed
HaoYang670 opened this issue Sep 13, 2022 · 2 comments
Closed

Float Array should not panic on DivideByZero in the Divide kernel #2719

HaoYang670 opened this issue Sep 13, 2022 · 2 comments
Labels
arrow Changes to the arrow crate bug

Comments

@HaoYang670
Copy link
Contributor

Describe the bug

Currently, the math_divide_op checks the DivideByZero error for all primitive types: https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/arithmetic.rs#L130-L138
This is not correct for the float type because 0.0/0.0 = NaN and NotZero/0.0 = (+/-) Infinity

To Reproduce

Expected behavior
Don't check the DivideByZero error for float type.

Additional context
@HaoYang670 HaoYang670 added the bug label Sep 13, 2022
@HaoYang670 HaoYang670 mentioned this issue Sep 13, 2022
Merged
@HaoYang670
Copy link
Contributor Author

Close this issue as we should follow the c++ impl

@HaoYang670 HaoYang670 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2022
@alamb
Copy link
Contributor

alamb commented Sep 16, 2022

label_issue.py automatically added labels {'arrow'} from #2717

@alamb alamb added the arrow Changes to the arrow crate label Sep 16, 2022
@alamb alamb mentioned this issue Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @HaoYang670