Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error[E0599]: no method named total_cmp found for struct f16 in the current scope #2926

Closed
alamb opened this issue Oct 25, 2022 · 1 comment · Fixed by #2927
Closed

error[E0599]: no method named total_cmp found for struct f16 in the current scope #2926

alamb opened this issue Oct 25, 2022 · 1 comment · Fixed by #2927
Labels
arrow Changes to the arrow crate bug

Comments

@alamb
Copy link
Contributor

alamb commented Oct 25, 2022

Reported by @Ted-Jiang in ASF slack

Describe the bug
If a user has an outdated Cargo.lock compile may fail:

yangjiang@LM-SHC-15009782 arrow-rs % rustup --version               
rustup 1.25.1 (bb60b1e89 2022-07-12)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.64.0 (a55dd71d5 2022-09-19)`
yangjiang@LM-SHC-15009782 arrow-rs % cargo test -p parquet     
   Compiling arrow v25.0.0 (/Users/yangjiang/CLionProjects/github/arrow-rs/arrow)
error[E0599]: no method named `total_cmp` found for struct `f16` in the current scope
   --> arrow/src/datatypes/native.rs:283:22
    |
283 |                 self.total_cmp(&rhs).is_eq()
    |                      ^^^^^^^^^ method not found in `f16`
...
309 | native_type_float_op!(f16, f16::ONE, f16::ZERO);
    | ----------------------------------------------- in this macro invocation
    |
    = note: this error originates in the macro `native_type_float_op` (in Nightly builds, run with -Z macro-backtrace for more info)

The problem can be solved by cargo update

@jhorstmann notes it is likely due to the fact we use half 2.1 features but only declare half 2.0

To Reproduce
not sure

Expected behavior
deps are correctly encoded

Additional context
slack: https://the-asf.slack.com/archives/C01QUFS30TD/p1666706313186039?thread_ts=1666704542.258779&cid=C01QUFS30TD

@alamb alamb added the bug label Oct 25, 2022
@alamb alamb added the arrow Changes to the arrow crate label Oct 28, 2022
@alamb
Copy link
Contributor Author

alamb commented Oct 28, 2022

label_issue.py automatically added labels {'arrow'} from #2927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant