Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RegexSet in arrow_csv::infer_field_schema #3211

Closed
tustvold opened this issue Nov 28, 2022 · 3 comments · Fixed by #3217
Closed

Use RegexSet in arrow_csv::infer_field_schema #3211

tustvold opened this issue Nov 28, 2022 · 3 comments · Fixed by #3217
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Using a RegexSet for matching multiple expressions simultaneously should yield a non-trivial speedup

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@tustvold tustvold added good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog help wanted labels Nov 28, 2022
@tustvold tustvold mentioned this issue Nov 28, 2022
Merged
@askoa
Copy link
Contributor

askoa commented Nov 28, 2022 •
edited
Loading

I'll pick this up.

Edit: I am not working on this. Thanks @tustvold for quick response.

@tustvold
Copy link
Contributor Author

I think @Jefffrey might already plan to pick this one up - #3209 (comment)

@Jefffrey
Copy link
Contributor

Feel free to go ahead and pick this one up, I'm in no rush to attempt this anyway @askoa

@askoa askoa mentioned this issue Nov 29, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use RegexSet for matching DataType
4 participants
@alamb @tustvold @Jefffrey @askoa