Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable some tests in arrow-cast crate #3219

Closed
viirya opened this issue Nov 29, 2022 · 0 comments · Fixed by #3222
Closed

Re-enable some tests in arrow-cast crate #3219

viirya opened this issue Nov 29, 2022 · 0 comments · Fixed by #3222
Labels
arrow Changes to the arrow crate bug

Comments

@viirya
Copy link
Member

viirya commented Nov 29, 2022

Describe the bug

We split out arrow-cast crate. Some tests moved to the crate need feature chrono-tz, but the crate don't have it. So these tests are not run in CI.

To Reproduce

Run cargo test --features chrono-tz test_can_cast_types -- --nocapture.

On master branch, the test is not run.

Normally we should see such output:

running 1 test
Test casting Binary --> Null
Test casting Binary --> Boolean
Test casting Binary --> Int8
Test casting Binary --> Int16
Test casting Binary --> Int32
Test casting Binary --> UInt64
Test casting Binary --> UInt8
Test casting Binary --> UInt16

Expected behavior

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants