Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make arithmetic kernels supports DictionaryArray of DecimalType #3254

Closed
viirya opened this issue Dec 2, 2022 · 0 comments · Fixed by #3255
Closed

Make arithmetic kernels supports DictionaryArray of DecimalType #3254

viirya opened this issue Dec 2, 2022 · 0 comments · Fixed by #3255
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Dec 2, 2022 •
edited
Loading

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

The arithmetic kernels such as add_dyn don't support DictionaryArray of DecimalType yet. We should extend the support.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Dec 2, 2022
@viirya viirya mentioned this issue Dec 2, 2022
Merged
@viirya viirya changed the title Make arithmetic kernels supports dictionary of decimal array Make arithmetic kernels supports DictionaryArray of DecimalType Dec 2, 2022
@alamb alamb added the arrow Changes to the arrow crate label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make arithmetic kernels supports DictionaryArray of DecimalType viirya/arrow-rs
2 participants
@viirya @alamb