Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlightSQL example is broken #3386

Closed
viirya opened this issue Dec 21, 2022 · 1 comment · Fixed by #3387
Closed

FlightSQL example is broken #3386

viirya opened this issue Dec 21, 2022 · 1 comment · Fixed by #3387
Labels
arrow-flight Changes to the arrow-flight crate bug

Comments

@viirya
Copy link
Member

viirya commented Dec 21, 2022

Describe the bug

FlightSQL example (arrow-flight/examples/flight_sql_server.rs) is broken. Running cargo test -p arrow-flight --features=flight-sql-experimental --examples got compilation error:

error[E0433]: failed to resolve: use of undeclared crate or module `fs`
   --> arrow-flight/examples/flight_sql_server.rs:504:17
    |                                                                                                              
504 |         let _ = fs::remove_file(path.clone());
    |                 ^^ use of undeclared crate or module `fs`  
                                                                                                                                                                                                                                       
error[E0412]: cannot find type `FlightSqlServiceClient` in this scope                                              
   --> arrow-flight/examples/flight_sql_server.rs:490:47                                                           
    |                                                                                                              
490 |     async fn client_with_uds(path: String) -> FlightSqlServiceClient {                                       
    |                                               ^^^^^^^^^^^^^^^^^^^^^^
    |                               
...

To Reproduce

Expected behavior

cargo test -p arrow-flight  --features=flight-sql-experimental --examples

   Compiling arrow-flight v29.0.0 (/arrow-rs/arrow-flight)
    Finished test [unoptimized + debuginfo] target(s) in 1.76s
     Running unittests examples/flight_sql_server.rs (target/debug/examples/flight_sql_server-609b62f910a8643f)

running 1 test
test tests::test_select_1 ... ok

Additional context

@alamb
Copy link
Contributor

alamb commented Dec 29, 2022

label_issue.py automatically added labels {'arrow-flight'} from #3387

@alamb alamb added the arrow-flight Changes to the arrow-flight crate label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow-flight Changes to the arrow-flight crate bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants