Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add modulus_dyn and modulus_scalar_dyn #3648

Closed
viirya opened this issue Feb 1, 2023 · 1 comment · Fixed by #3649
Closed

Add modulus_dyn and modulus_scalar_dyn #3648

viirya opened this issue Feb 1, 2023 · 1 comment · Fixed by #3649
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Feb 1, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

While working on fixing a issue on DataFusion (apache/datafusion#5150), I realized that modulus op doesn't provide dyn and scalar_dyn kernels.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Feb 1, 2023
@viirya viirya mentioned this issue Feb 1, 2023
Merged
@tustvold tustvold added the arrow Changes to the arrow crate label Feb 10, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #3649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add modulus_dyn and modulus_scalar_dyn viirya/arrow-rs
2 participants
@viirya @tustvold