Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow precision loss on multiplying decimal arrays #3689

Closed
viirya opened this issue Feb 10, 2023 · 1 comment · Fixed by #3690
Closed

Allow precision loss on multiplying decimal arrays #3689

viirya opened this issue Feb 10, 2023 · 1 comment · Fixed by #3690
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Feb 10, 2023

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Current multiply kernel cannot allow precision loss when performing on decimal arrays. However, this is a requirement for decimal multiplication in practice, e.g. Spark supports it. It is difficult to ask users to manually adjust input data.

Describe the solution you'd like

It can image that such operation is slower than current multiply, so making it as default seems not acceptable. It seems more reasonable to provide additional decimal specific multiply kernel for that.

Describe alternatives you've considered

We cannot do this.

Additional context

@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Feb 10, 2023
@tustvold tustvold added the arrow Changes to the arrow crate label Mar 24, 2023
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #3690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants