Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot access pen state website on arrow-row #5238

Closed
thomas-k-cameron opened this issue Dec 23, 2023 · 5 comments · Fixed by #5239
Closed

Cannot access pen state website on arrow-row #5238

thomas-k-cameron opened this issue Dec 23, 2023 · 5 comments · Fixed by #5239
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@thomas-k-cameron
Copy link
Contributor

thomas-k-cameron commented Dec 23, 2023 •
edited
Loading

Describe the bug
Arrow-row has a link to pen state's website but it is not accessible; It says Token is required.

link

{"message":"Token is required"}

To Reproduce
Click the part that it says normalized for sorting here.
https://docs.rs/arrow-row/49.0.0/arrow_row/index.html

image

Expected behavior
It shows whatever that it has to show.

Additional context
NA
@tustvold
Copy link
Contributor

Can be replaced with a link to http://wwwlgis.informatik.uni-kl.de/archiv/wwwdvs.informatik.uni-kl.de/courses/DBSREAL/SS2005/Vorlesungsunterlagen/Implementing_Sorting.pdf

@tustvold tustvold added documentation Improvements or additions to documentation good first issue Good for newcomers enhancement Any new improvement worthy of a entry in the changelog and removed bug labels Dec 23, 2023
@thomas-k-cameron
Copy link
Contributor Author

thomas-k-cameron commented Dec 24, 2023 •
edited
Loading

@tustvold
Would it possible to include these pdf file into this repository?

That website can have the same issue in future.

@tustvold
Copy link
Contributor

I would prefer not to, as it stands a good chance of causing legal headaches down the line

@thomas-k-cameron thomas-k-cameron mentioned this issue Dec 24, 2023
Merged
@thomas-k-cameron
Copy link
Contributor Author

OK, I made a PR. Hope this helps!
#5239

@tustvold tustvold added the arrow Changes to the arrow crate label Jan 5, 2024
@tustvold
Copy link
Contributor

tustvold commented Jan 5, 2024

label_issue.py automatically added labels {'arrow'} from #5239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update arrow-row docs URL thomas-k-cameron/arrow-rs
2 participants
@tustvold @thomas-k-cameron