Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused import in nightly rust #5476

Closed
XiangpengHao opened this issue Mar 6, 2024 · 7 comments · Fixed by #5477
Closed

Unused import in nightly rust #5476

XiangpengHao opened this issue Mar 6, 2024 · 7 comments · Fixed by #5477
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug parquet Changes to the parquet crate

Comments

@XiangpengHao
Copy link
Contributor

Describe the bug

With this pr been merged to nightly rust: rust-lang/rust#117772
The tracking for unused import has been improved, resulting numerous compiler warnings when building arrow-rs with nightly rust.

To Reproduce

rustup default nightly
cargo check

Expected behavior

Additional context
@XiangpengHao XiangpengHao mentioned this issue Mar 6, 2024
Merged
@XiangpengHao
Copy link
Contributor Author

Maybe it should be a feature request not bug...

@Kikkon
Copy link
Contributor

Kikkon commented Mar 9, 2024

Hi, @tustvold . Following the above method. I have reproduced the issue on my machine, and there are over 40 warnings. I think i can submit a pull request to clean up these unused import ?

@tustvold
Copy link
Contributor

tustvold commented Mar 9, 2024

I believe this is already being worked on in #5477

@tustvold tustvold added the parquet Changes to the parquet crate label Mar 15, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'parquet'} from #5477

@tustvold tustvold added the arrow Changes to the arrow crate label Mar 15, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #5477

@tustvold tustvold added the arrow-flight Changes to the arrow-flight crate label Mar 15, 2024
@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow-flight'} from #5477

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'parquet-derive'} from #5477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate bug parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused import detected by nightly rust XiangpengHao/arrow-rs
3 participants
@tustvold @XiangpengHao @Kikkon