Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPC support for Union Array #654

Closed
paddyhoran opened this issue Aug 2, 2021 · 2 comments · Fixed by #1140
Closed

Add IPC support for Union Array #654

paddyhoran opened this issue Aug 2, 2021 · 2 comments · Fixed by #1140
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@paddyhoran
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Although UnionArray is implemented it has no IPC support.

Describe the solution you'd like
UnionArray should pass the integration tests.

Describe alternatives you've considered
NA

Additional context
NA

@paddyhoran paddyhoran added the enhancement Any new improvement worthy of a entry in the changelog label Aug 2, 2021
@sum12
Copy link
Contributor

sum12 commented Oct 27, 2021

If I am reading the code correctly arrow/src/ipc/reader::create_array needs to know how to recognize a UnionArray and create one accordingly. I can imagine using arrow/src/array/array_union.new or arrow/src/array/array_union::try_new.

if this is still relevant. Could you help me break this down to in some steps ? I would like to contribute this.

@paddyhoran
Copy link
Contributor Author

Hi @sum12,

I think it would make more sense to start with #85 and then #814. I believe they will be needed first. This issue is more high level and the success criteria would be passing the integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants