diff --git a/r/configure b/r/configure index 4f09cfdc4419b..e48bd2f010b4a 100755 --- a/r/configure +++ b/r/configure @@ -413,7 +413,7 @@ CXX17FLAGS=`"${R_HOME}"/bin/R CMD config CXX17FLAGS` CXX17STD=`"${R_HOME}"/bin/R CMD config CXX17STD` CPPFLAGS=`"${R_HOME}"/bin/R CMD config CPPFLAGS` TEST_CMD="${CXX17} ${CPPFLAGS} ${PKG_CFLAGS} ${CXX17FLAGS} ${CXX17STD} -xc++ -" -echo "#include $PKG_TEST_HEADER" | ${TEST_CMD} >/dev/null 2>&1 +TEST_ERROR=$(echo "#include $PKG_TEST_HEADER" | ${TEST_CMD} -o /dev/null 2>&1) if [ $? -eq 0 ]; then # Prepend PKG_DIRS to PKG_LIBS and write to Makevars @@ -428,7 +428,12 @@ else echo "------------------------- NOTE ---------------------------" echo "There was an issue preparing the Arrow C++ libraries." echo "See https://arrow.apache.org/docs/r/articles/install.html" - echo "---------------------------------------------------------" + echo "----------------------------------------------------------" + echo "" + echo "Test compile error: ${TEST_ERROR}" + echo "Failing compile command: ${TEST_CMD}" + echo "PKG_CFLAGS=$PKG_CFLAGS" + echo "PKG_LIBS=$PKG_LIBS" PKG_LIBS="" PKG_CFLAGS="" exit 1 diff --git a/r/tools/nixlibs.R b/r/tools/nixlibs.R index 03cbfbc5e91a8..b003e7cea80d4 100644 --- a/r/tools/nixlibs.R +++ b/r/tools/nixlibs.R @@ -99,16 +99,12 @@ download_binary <- function(lib) { libfile <- paste0("arrow-", VERSION, ".zip") binary_url <- paste0(arrow_repo, "bin/", lib, "/arrow-", VERSION, ".zip") if (try_download(binary_url, libfile)) { - if (!quietly) { - lg("Successfully retrieved C++ binaries (%s)", lib) - } + lg("Successfully retrieved libarrow (%s)", lib) } else { - if (!quietly) { lg( - "Downloading libarrow binary failed for version %s (%s)\n at %s", + "Downloading libarrow failed for version %s (%s)\n at %s", VERSION, lib, binary_url ) - } libfile <- NULL } # Explicitly setting the env var to "false" will skip checksum validation @@ -140,11 +136,11 @@ download_binary <- function(lib) { checksum_ok <- system2(checksum_cmd, args = checksum_args) if (checksum_ok != 0) { - cat("*** Checksum validation failed for libarrow binary: ", libfile, "\n") + lg("Checksum validation failed for libarrow: %s/%s", lib, libfile) unlink(libfile) libfile <- NULL } else { - cat("*** Checksum validated successfully for libarrow binary: ", libfile, "\n") + lg("Checksum validated successfully for libarrow: %s/%s", lib, libfile) } }