Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] open_dataset - format is unclear #38178

Open
csgillespie opened this issue Oct 10, 2023 · 4 comments
Open

[R] open_dataset - format is unclear #38178

csgillespie opened this issue Oct 10, 2023 · 4 comments
Labels
Component: R Type: usage Issue is a user question

Comments

@csgillespie
Copy link

csgillespie commented Oct 10, 2023

Describe the bug, including details regarding any error messages, version, and platform.

library(arrow)
?open_dataset

gives the function sig as

...
format = c("parquet", "arrow", "ipc", "feather", "csv", "tsv", "text", "json"),

However, the docs in ?open_dataset don't mention json. Which would mean it's not supported?


If I was being pedantic, write_dataset() is slightly odd.

  • CSV == test in open_, but not in write_
  • open_ reads in JSON / tsv, but write_ doesn't

Component(s)

R

@thisisnic thisisnic changed the title open_dataset - format is unclear [R] open_dataset - format is unclear Oct 11, 2023
@thisisnic
Copy link
Member

Thanks @csgillespie, this kind of feedback from our user community is super helpful!

the docs in ?open_dataset don't mention json.

Looks like we missed mentioning JSON in the docs when we added that functionality - thanks for spotting that!

CSV == test in open_, but not in write_

Sorry, I'm a but unsure what you mean by this, mind rephrasing?

open_ reads in JSON / tsv, but write_ doesn't

Writing JSON files isn't currently supported in the arrow R package as it's not implemented in Arrow C++; if it's something that would be useful, you could open a C++ feature request ticket?

Writing tsv files is supported, though the released package's version of the docs don't reflect that. However, this is fixed in the dev version (see dev docs here).

@thisisnic
Copy link
Member

I've opened #38216 for documenting the option of JSON in the format parameter

@thisisnic
Copy link
Member

thisisnic commented Oct 11, 2023

Aha, I see, CSV == text. Yep, we should update that too, here's the ticket #38217

@thisisnic
Copy link
Member

Interested in submitting a PR at all @csgillespie?

@thisisnic thisisnic added Type: usage Issue is a user question and removed Type: bug labels Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: R Type: usage Issue is a user question
Projects
None yet
Development

No branches or pull requests

2 participants