Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration testing of Pipeline drain in Go SDK #21681

Closed
damccorm opened this issue Jun 5, 2022 · 5 comments · Fixed by #17814
Closed

Integration testing of Pipeline drain in Go SDK #21681

damccorm opened this issue Jun 5, 2022 · 5 comments · Fixed by #17814
Assignees
Labels

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 5, 2022

Add an integration test for pipeline drain feature BEAM-11106 added in https://github.com/apache/beam/pull/17432. 

Imported from Jira BEAM-14406. Original Jira may contain additional context.
Reported by: riteshghorse.

@damccorm
Copy link
Contributor Author

damccorm commented Jun 5, 2022

Unable to assign user @riteshghorse. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.

@riteshghorse
Copy link
Contributor

@damccorm

@damccorm
Copy link
Contributor Author

damccorm commented Jun 6, 2022

FWIW, this limitation should be addressed by #21719

@riteshghorse
Copy link
Contributor

Great, thanks!

@lostluck
Copy link
Contributor

lostluck commented Jun 9, 2022

I'll note that we can probably make a special handle for Dataflow jobs so we can programmatically trigger the drain after we have the job confirmed as running.

It wouldn't be able to run via ptest, but that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants