Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcp bom to 26.50.0 #33192

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Update gcp bom to 26.50.0 #33192

merged 7 commits into from
Jan 3, 2025

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Nov 22, 2024

This notably includes upgrading protobuf. Changes are segmented by commit:

  • Update the bom with the bom updater script - e8b2c0a
  • Remove null checks - 5762104 - this is because proto fields can no longer be null (they'll at least have a default implementation)
  • Update google_cloud_bigdataoss_version - 4a5efdd - this is because gcsio was not compatible with Protobuf 4 until this release.
  • Update aws client versions to be compatible with Protobuf 4 - b72d791

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm marked this pull request as draft November 22, 2024 18:08
@damccorm
Copy link
Contributor Author

Some failures are caused because proto fields can no longer be null (they'll at least have a default implementation). Addressing this now

@damccorm damccorm marked this pull request as ready for review January 2, 2025 13:19
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @Abacn for label build.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm
Copy link
Contributor Author

damccorm commented Jan 2, 2025

cc/ @ldetmer

@liferoad liferoad added this to the 2.63.0 Release milestone Jan 2, 2025
Copy link
Contributor

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damccorm damccorm merged commit 7e6cf18 into master Jan 3, 2025
26 checks passed
@damccorm damccorm deleted the users/damccorm/bom branch January 3, 2025 14:42
@Abacn
Copy link
Contributor

Abacn commented Jan 7, 2025

@damccorm
Copy link
Contributor Author

damccorm commented Jan 7, 2025

Thanks - #33525 should fix the first issue, working on a fix for the second

@Abacn
Copy link
Contributor

Abacn commented Jan 7, 2025

Thanks, persumably debezium test is the same cause? (which could be trickier as we have conflict protobuf version for DebeziumIO then)

@damccorm
Copy link
Contributor Author

damccorm commented Jan 7, 2025

Yeah, I'm seeing if I can upgrade our debezium dependency version. That does seem like a larger issue though

@damccorm
Copy link
Contributor Author

damccorm commented Jan 7, 2025

One thing which may help is that the problematic dependency is actually a test-only dependency -

testImplementation group: 'io.debezium', name: 'debezium-connector-postgres', version: '1.3.1.Final'
- debezium-connector-postgres

So worst case, we could probably only force the dependency for testing postgres, but that is definitely not an awesome place to land...

@damccorm damccorm mentioned this pull request Jan 8, 2025
3 tasks
stankiewicz pushed a commit to stankiewicz/beam that referenced this pull request Jan 16, 2025
* Update bom to 26.50.0

* Remove null checks

* Update gcs

* Bump aws versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants