Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitized integration name on Windows contains whole path #1462

Closed
rrayst opened this issue May 26, 2020 · 1 comment · Fixed by #1484
Closed

sanitized integration name on Windows contains whole path #1462

rrayst opened this issue May 26, 2020 · 1 comment · Fixed by #1484
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@rrayst
Copy link

rrayst commented May 26, 2020

Version: 1.0.0-nightly.202005130003

Problem: On Windows, the whole file path passed to kamel run is used as the integration name.

C:\ > kamel run git\camel-k\examples\Sample.java
integration "gitcamel-kexamplessample" created

On Linux, this is not the case.

Workaround: Using a / instead of a \ works around the issue.

C:\ > kamel run git\camel-k\examples/Sample.java
integration "sample" created

Possible solution: Use filepath.Base(..) instead of path.Base(..) in https://github.com/apache/camel-k/blob/1.0.0-nightly.202005130003/pkg/util/kubernetes/sanitize.go#L33 .

@nicolaferraro nicolaferraro added the kind/bug Something isn't working label May 26, 2020
@nicolaferraro nicolaferraro added this to the 1.0.0 milestone May 26, 2020
@nicolaferraro
Copy link
Member

Yeah, we should try to fix it before next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants