From e0e0ead00502891a4fe5083c02ba25c01652f6ab Mon Sep 17 00:00:00 2001 From: onebox-li Date: Fri, 20 Dec 2024 12:12:52 +0800 Subject: [PATCH 1/2] improve location hashcode --- .../apache/celeborn/common/protocol/PartitionLocation.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java b/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java index 8e76f348864..0bd9da8522b 100644 --- a/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java +++ b/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java @@ -286,7 +286,12 @@ public boolean equals(Object other) { @Override public int hashCode() { - return (id + epoch + host + rpcPort + pushPort + fetchPort).hashCode(); + int result = (id + "-" + epoch).hashCode(); + result = 31 * result + host.hashCode(); + result = 31 * result + rpcPort; + result = 31 * result + pushPort; + result = 31 * result + replicatePort; + return result; } @Override From 4c4776e48713144e996bc7081516b0df92130fcf Mon Sep 17 00:00:00 2001 From: onebox-li Date: Fri, 20 Dec 2024 14:44:58 +0800 Subject: [PATCH 2/2] fix --- .../org/apache/celeborn/common/protocol/PartitionLocation.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java b/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java index 0bd9da8522b..b8b87e5fe45 100644 --- a/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java +++ b/common/src/main/java/org/apache/celeborn/common/protocol/PartitionLocation.java @@ -290,7 +290,7 @@ public int hashCode() { result = 31 * result + host.hashCode(); result = 31 * result + rpcPort; result = 31 * result + pushPort; - result = 31 * result + replicatePort; + result = 31 * result + fetchPort; return result; }