Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default targetSdkVersion value in APK build #666

Closed
3 tasks done
brody4hire opened this issue Feb 12, 2019 · 1 comment
Closed
3 tasks done

Wrong default targetSdkVersion value in APK build #666

brody4hire opened this issue Feb 12, 2019 · 1 comment
Assignees
Labels

Comments

@brody4hire
Copy link

Bug Report

Problem

What is expected to happen?

If I would build with cordova-android from master branch of GitHub, with no special targetSdkVersion value explicitly defined, the resulting APK should have correct default value of targetSdkVersion.

What does actually happen?

If I would add cordova-android platform from GitHub to new Cordova project as follows:

cordova platform add https://github.com/apache/cordova-android#master

then do cordova build android and then check the target SDK version as follows:

aapt list -a platforms/android/app/build/outputs/apk/debug/app-debug.apk | grep -i sdkversion

I get the following result:

    A: android:compileSdkVersion(0x01010572)=(type 0x10)0x1c
    A: android:compileSdkVersionCodename(0x01010573)="9" (Raw: "9")
      A: android:minSdkVersion(0x0101020c)=(type 0x10)0x13
      A: android:targetSdkVersion(0x01010270)="__APILEVEL__" (Raw: "__APILEVEL__")

Note the nonsense android:targetSdkVersion value.

Information

see above

This issue is a result of merged PR #664, which was raised by me.

Command or Code

see above

Environment, Platform, Device

mac OS

Version information

Cordova CLI version: 8.1.2 ([email protected])

Cordova platforms: cordova-android @ bb45f4f from master branch

Other frameworks: none

Operating System: mac OS (10.13.6)

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@brody4hire brody4hire added the bug label Feb 12, 2019
@brody4hire brody4hire self-assigned this Feb 12, 2019
@brody4hire
Copy link
Author

I can think of the following alternative solutions:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant