Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cordova-create] Do not copy "missing" files from default template (§5) #102

Closed
raphinesse opened this issue Jul 5, 2018 · 1 comment
Closed

[cordova-create] Do not copy "missing" files from default template (§5) #102

raphinesse opened this issue Jul 5, 2018 · 1 comment

Comments

@raphinesse
Copy link

Some files and dirs are copied to dest from cordova-app-hello-world if they
are not present in the custom template being used.

Current situation

These files and dirs are:

  • www
  • hooks
  • config.xml

Pain Points

  • File list is outdated (hooks dir has been deprecated, package.json is missing)
  • Template authors might be surprised to see files they did not use

Proposal

KISS and remove this behavior

  • Makes cordovaCreate more agnostic to the template layout
  • Principle of least surprise for template authors
  • Less maintenance

Evolved from #89. Possibly related to #78
@raphinesse raphinesse mentioned this issue Jul 5, 2018
Closed
@raphinesse raphinesse mentioned this issue Sep 10, 2018
Closed
@raphinesse
Copy link
Author

This issue was moved to apache/cordova-create#24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raphinesse