Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engines to use variables #323

Merged
merged 1 commit into from
Jun 10, 2018

Conversation

jcesarmobile
Copy link
Member

Platforms affected

Android

What does this PR do?

Update plugin.xml and package.json engines to the ones that allow variables

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@jcesarmobile
Copy link
Member Author

@macdonst sorry, I missed this, the variable only works on cordova 7.1.0 and greater.

Do you think we should do a minor bump for this?

@shazron
Copy link
Member

shazron commented May 21, 2018

I would recommend a minor bump.

@jcesarmobile
Copy link
Member Author

@shazron updated the engine to apply to 4.1.0.
Didn't bump the plugin version yet as I think that is done on the plugin release process.

@jcesarmobile jcesarmobile requested review from shazron and macdonst May 30, 2018 20:08
@jcesarmobile jcesarmobile merged commit 6899c5e into apache:master Jun 10, 2018
@jcesarmobile jcesarmobile deleted the engines-update branch June 10, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants