diff --git a/.github/workflows/miri.yml b/.github/workflows/miri.yml deleted file mode 100644 index a07ecc35e..000000000 --- a/.github/workflows/miri.yml +++ /dev/null @@ -1,49 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. - -name: Run Miri Safety Checks - -on: - push: - paths-ignore: - - "doc/**" - - "docs/**" - - "**.md" - pull_request: - paths-ignore: - - "doc/**" - - "docs/**" - - "**.md" - # manual trigger - # https://docs.github.com/en/actions/managing-workflow-runs/manually-running-a-workflow - workflow_dispatch: - -jobs: - miri: - name: "Miri" - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - - name: Install Miri - run: | - rustup toolchain install nightly --component miri - rustup override set nightly - cargo miri setup - - name: Test with Miri - run: | - cd native - MIRIFLAGS="-Zmiri-disable-isolation" cargo miri test diff --git a/native/core/src/execution/datafusion/planner.rs b/native/core/src/execution/datafusion/planner.rs index 5154e0c0a..251faf645 100644 --- a/native/core/src/execution/datafusion/planner.rs +++ b/native/core/src/execution/datafusion/planner.rs @@ -2504,7 +2504,6 @@ mod tests { } #[test] - #[cfg_attr(miri, ignore)] // miri can't call foreign function `rust_psm_stack_pointer` fn spark_plan_metrics_filter() { let op_scan = create_scan(); let op = create_filter(op_scan, 0); @@ -2518,7 +2517,6 @@ mod tests { } #[test] - #[cfg_attr(miri, ignore)] // miri can't call foreign function `rust_psm_stack_pointer` fn spark_plan_metrics_hash_join() { let op_scan = create_scan(); let op_join = Operator {