Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of dropDuplicates #1275

Open
andygrove opened this issue Jan 13, 2025 · 1 comment
Open

Improve performance of dropDuplicates #1275

andygrove opened this issue Jan 13, 2025 · 1 comment
Labels
enhancement New feature or request performance
Milestone

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Comet is 4x slower than Spark for the following query:

spark.read.parquet("/mnt/bigdata/tpcds/sf100/store_sales.parquet") \
    .repartition("ss_item_sk") \
    .dropDuplicates(["ss_item_sk", "ss_quantity"]) \
    .write.parquet("output.parquet")

If I remove the dropDuplicates call, I see similar performance between Comet and Spark.

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added enhancement New feature or request performance labels Jan 13, 2025
@andygrove
Copy link
Member Author

Disabling Comet aggregation improves performance from 230s to 64s and is slightly faster than Spark at 78s.

@kazuyukitanimura kazuyukitanimura added this to the 0.6.0 milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

No branches or pull requests

2 participants